Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bijoin plan node #4977

Merged
merged 4 commits into from
Dec 3, 2022
Merged

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Dec 3, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

  • Rename BiJoin to HashJoin
  • Rename BiInnerJoin to HashInnerJoin
  • Rename BiLeftJoin to HashLeftJoin
  • Rename BiCartesianProduct to CrossJoin

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

jievince
jievince previously approved these changes Dec 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Base: 76.85% // Head: 76.84% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (70e3394) compared to base (4f1fe76).
Patch coverage: 95.79% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4977      +/-   ##
==========================================
- Coverage   76.85%   76.84%   -0.02%     
==========================================
  Files        1101     1105       +4     
  Lines       81227    81447     +220     
==========================================
+ Hits        62426    62584     +158     
- Misses      18801    18863      +62     
Impacted Files Coverage Δ
src/graph/executor/algo/CartesianProductExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/InnerJoinExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/JoinExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/LeftJoinExecutor.h 100.00% <ø> (ø)
src/graph/optimizer/rule/RemoveNoopProjectRule.cpp 93.61% <ø> (ø)
src/graph/planner/plan/ExecutionPlan.h 100.00% <ø> (ø)
src/graph/planner/plan/PlanNode.h 89.42% <ø> (ø)
src/graph/planner/plan/PlanNodeVisitor.h 100.00% <ø> (ø)
src/graph/service/CloudAuthenticator.cpp 0.00% <0.00%> (ø)
src/graph/visitor/PrunePropertiesVisitor.h 50.00% <ø> (ø)
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yixinglu yixinglu requested a review from jievince December 3, 2022 05:47
@codesigner codesigner merged commit 8adec8d into vesoft-inc:master Dec 3, 2022
@yixinglu yixinglu deleted the rename-bijoin branch December 3, 2022 12:28
codesigner pushed a commit to codesigner/nebula that referenced this pull request Dec 5, 2022
* Rename BiJoin to HashJoin

* Rename cartesian product to cross join

* Fix compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants