Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property pruner do not parse none exist tag correctly #4949

Merged

Conversation

codesigner
Copy link
Contributor

@codesigner codesigner commented Nov 29, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

fix #4733

Fix property pruner do not parse none exist tag correctly.

Description:

Change 1

Continue visiting Project's Expression when encounter TagNotExist error.

Query to produce bug:

MATCH (v:player)-[e:like]->(t) WHERE v.player.name=='Tim Duncan' RETURN v.player.name, v.x.y, v.player.age

When PrunerPropertiesVisitor visit project node, it visit three TagPropertyExpression:
v.player.name, v.x.y, v.player.age, the x tag in v.x.y does not exist, and it will break the for loop, cause missed analyzing the 3rd Expression v.player.age, player.age is not properly handled.

  • Before
(root@nebula) [nba]> match (v:player)-[e:like]->(t) where v.player.name=='Tim Duncan'  return v.player.name, v.x.y, v.player.age
+---------------+----------+--------------+
| v.player.name | v.x.y    | v.player.age |
+---------------+----------+--------------+
| "Tim Duncan"  | __NULL__ | __NULL__     |
| "Tim Duncan"  | __NULL__ | __NULL__     |
+---------------+----------+--------------+

  • After
(root@nebula) [nba]> match (v:player)-[e:like]->(t) where v.player.name=='Tim Duncan'  return v.player.name, v.x.y, v.player.age
+---------------+----------+--------------+
| v.player.name | v.x.y    | v.player.age |
+---------------+----------+--------------+
| "Tim Duncan"  | __NULL__ | 42           |
| "Tim Duncan"  | __NULL__ | 42           |
+---------------+----------+--------------+
Change 2
  • Stauts returned from meta does not have properly set error code, which is needed by Optimizer to distingush separate error condition, (like Change1 use the Status::isTagNotFound() to continue property pruning).
  • Changed some Status from general Error to specific error code for SpaceNotFound, TagNotFount, EdgeNotFound, IndexNotFound

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • TCK
  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codesigner codesigner added ready-for-testing PR: ready for the CI test ready for review labels Nov 29, 2022
@codesigner codesigner force-pushed the bugfix_prop_pruner_on_invalid_tag branch from 0f98d29 to fab4d9f Compare November 29, 2022 08:43
@codesigner codesigner requested review from nevermore3, czpmango, yixinglu and shanlai and removed request for nevermore3, czpmango and yixinglu November 29, 2022 10:53
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@codesigner codesigner merged commit 0ff53a3 into vesoft-inc:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when match ngql return contains the wrong tag, properties(v) returns incompletely
4 participants