-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix property pruner do not parse none exist tag correctly #4949
Merged
codesigner
merged 11 commits into
vesoft-inc:master
from
codesigner:bugfix_prop_pruner_on_invalid_tag
Nov 29, 2022
Merged
Fix property pruner do not parse none exist tag correctly #4949
codesigner
merged 11 commits into
vesoft-inc:master
from
codesigner:bugfix_prop_pruner_on_invalid_tag
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesigner
force-pushed
the
bugfix_prop_pruner_on_invalid_tag
branch
from
November 29, 2022 08:43
0f98d29
to
fab4d9f
Compare
codesigner
requested review from
nevermore3,
czpmango,
yixinglu and
shanlai
and removed request for
nevermore3,
czpmango and
yixinglu
November 29, 2022 10:53
jievince
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yixinglu
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent!
nevermore3
approved these changes
Nov 29, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
fix #4733
Fix property pruner do not parse none exist tag correctly.
Description:
Change 1
Continue visiting Project's Expression when encounter TagNotExist error.
Query to produce bug:
When PrunerPropertiesVisitor visit project node, it visit three TagPropertyExpression:
v.player.name
,v.x.y
,v.player.age
, the x tag inv.x.y
does not exist, and it will break the for loop, cause missed analyzing the 3rd Expressionv.player.age
, player.age is not properly handled.Change 2
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: