Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dup alias in MATCH #4940

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Fix dup alias in MATCH #4940

merged 4 commits into from
Dec 2, 2022

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Nov 28, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix https://github.com/vesoft-inc/nebula-ent/issues/1605, https://github.com/vesoft-inc/nebula-ent/issues/1727

Description:

Emit addVertises node if the last node in the pattern is duplicated.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • TCK

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Aiee Aiee added the ready-for-testing PR: ready for the CI test label Nov 28, 2022
yixinglu
yixinglu previously approved these changes Nov 30, 2022
@Sophie-Xie Sophie-Xie requested a review from jievince December 1, 2022 01:49
@Aiee Aiee requested review from yixinglu and xtcyclist December 2, 2022 03:30
@yixinglu yixinglu merged commit 8fff4aa into vesoft-inc:master Dec 2, 2022
@Aiee Aiee deleted the fix-alias branch December 2, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants