-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor enhancement about listener #4931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
* // Main interface to process logs, listener need to apply the committed log entry to their | ||
* // state machine. Once apply succeeded, user should call persist() to make their progress | ||
* // persisted. | ||
* virtual void processLogs() = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a small question:
Why does the function comment here exist? Can it be removed?
Only leave functions, such as the above function, only need to leave
virtual void processLogs() = 0;
Otherwise, there are two copies of these comments, which feels a bit redundant?
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Also a prepare work:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: