use libcurl #4891
use libcurl #4891
Conversation
Codecov ReportBase: 84.56% // Head: 76.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4891 +/- ##
==========================================
- Coverage 84.56% 76.95% -7.61%
==========================================
Files 1358 1110 -248
Lines 136387 82178 -54209
==========================================
- Hits 115331 63238 -52093
+ Misses 21056 18940 -2116
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| }; | ||
|
|
||
| struct HttpResponse { | ||
| CURLcode curlCode; |
There was a problem hiding this comment.
CURLcode is a int not a enum? Didn't find it in this PR
There was a problem hiding this comment.
It's an integer and defined by libcurl
| static HttpResponse post(const std::string& url, | ||
| const std::vector<std::string>& headers, | ||
| const std::string& body); | ||
| static HttpResponse delete_(const std::string& url, const std::vector<std::string>& headers); |
There was a problem hiding this comment.
del? Not a big issue, up to you
There was a problem hiding this comment.
Emm, both are OK. But I don't want to change it:)
Maybe someone who doesn't like delete_ will modify it one day.
https://github.com/vesoft-inc/nebula-third-party It's included in third-party |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Use libcurl instead of invoke "/usr/bin/curl" with popen
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: