Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow redefined aliases in with. #4868

Merged
merged 10 commits into from
Nov 28, 2022
Merged

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Nov 14, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close https://github.com/vesoft-inc/nebula-ent/issues/1579

Description:

Redefined aliases shall be allowed in the with clause.

How do you solve it?

  • Removed the guard on checking redefined aliases. Without the with clause, redefined aliases work fine, except that return * would report redudant errors.
  • Remove redudant columns in the return clause. For example, the return as in match (v)-[e]-(v) where .... return * shall not contain two vs.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • TCK

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist added the ready-for-testing PR: ready for the CI test label Nov 14, 2022
@xtcyclist xtcyclist added ready for review cherry-pick-v3.3 PR: need cherry-pick to this version and removed cherry-pick-v3.3 PR: need cherry-pick to this version ready for review labels Nov 15, 2022
jievince
jievince previously approved these changes Nov 16, 2022
Shylock-Hg
Shylock-Hg previously approved these changes Nov 17, 2022
src/graph/validator/MatchValidator.cpp Outdated Show resolved Hide resolved
@xtcyclist xtcyclist dismissed stale reviews from Shylock-Hg and jievince via 165bc38 November 17, 2022 07:25
Shylock-Hg
Shylock-Hg previously approved these changes Nov 17, 2022
@xtcyclist xtcyclist requested a review from Aiee November 23, 2022 09:28
@xtcyclist xtcyclist force-pushed the fix_ent#1579 branch 3 times, most recently from f5c77d2 to 5b22a17 Compare November 24, 2022 04:24
@xtcyclist xtcyclist merged commit f485455 into vesoft-inc:master Nov 28, 2022
@xtcyclist xtcyclist deleted the fix_ent#1579 branch November 28, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants