-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow redefined aliases in with. #4868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtcyclist
force-pushed
the
fix_ent#1579
branch
from
November 15, 2022 05:37
bb28ef1
to
350c2f9
Compare
xtcyclist
added
ready for review
cherry-pick-v3.3
PR: need cherry-pick to this version
and removed
cherry-pick-v3.3
PR: need cherry-pick to this version
ready for review
labels
Nov 15, 2022
xtcyclist
force-pushed
the
fix_ent#1579
branch
from
November 15, 2022 07:21
350c2f9
to
90fe383
Compare
jievince
previously approved these changes
Nov 16, 2022
Shylock-Hg
reviewed
Nov 16, 2022
yixinglu
reviewed
Nov 16, 2022
Shylock-Hg
previously approved these changes
Nov 17, 2022
Shylock-Hg
previously approved these changes
Nov 17, 2022
xtcyclist
force-pushed
the
fix_ent#1579
branch
2 times, most recently
from
November 17, 2022 07:57
c59cd4d
to
5a618f5
Compare
xtcyclist
force-pushed
the
fix_ent#1579
branch
from
November 18, 2022 02:48
5a618f5
to
4997009
Compare
xtcyclist
force-pushed
the
fix_ent#1579
branch
2 times, most recently
from
November 22, 2022 02:30
f5b66ed
to
28a3108
Compare
Aiee
reviewed
Nov 22, 2022
xtcyclist
force-pushed
the
fix_ent#1579
branch
from
November 22, 2022 03:15
28a3108
to
c278831
Compare
xtcyclist
force-pushed
the
fix_ent#1579
branch
3 times, most recently
from
November 24, 2022 04:24
f5c77d2
to
5b22a17
Compare
xtcyclist
force-pushed
the
fix_ent#1579
branch
from
November 28, 2022 01:57
5b22a17
to
6230d29
Compare
Shylock-Hg
approved these changes
Nov 28, 2022
jievince
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close https://github.com/vesoft-inc/nebula-ent/issues/1579
Description:
Redefined aliases shall be allowed in the with clause.
How do you solve it?
with
clause, redefined aliases work fine, except thatreturn *
would report redudant errors.match (v)-[e]-(v) where .... return *
shall not contain twov
s.Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: