-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/inner variable race condition #4850
Fix/inner variable race condition #4850
Conversation
…x/inner-variable-race-condition
…k-Hg/nebula into fix/inner-variable-race-condition
Codecov ReportBase: 84.56% // Head: 84.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4850 +/- ##
==========================================
+ Coverage 84.56% 84.62% +0.06%
==========================================
Files 1358 1358
Lines 136387 136396 +9
==========================================
+ Hits 115331 115425 +94
+ Misses 21056 20971 -85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #4845
Close https://github.com/vesoft-inc/nebula-ent/issues/1576
Close #4843
Description:
In previous, try to force user create list comprehension/reduce/predication expression with unique variable name, but this change lead to too much wired object dependencies, so this PR just fix two mistake generation of inner variable.
In the future, plan to refactor inner variable by remove it from the global variable map to Expression Eval Context. This will resolve these problems completely and could fix the related #4844 .
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: