Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to make mkdocs page #469

Merged
merged 6 commits into from
Jun 10, 2019
Merged

update docs to make mkdocs page #469

merged 6 commits into from
Jun 10, 2019

Conversation

amber-moe
Copy link
Contributor

I've added three new files in 'docs':
index.md
Contribute-to-documentation.md
Developer-documentation-style-guide.md
changed some layout in get-started.md
After the doc is done, I will make a doc site based on that.

@amber-moe amber-moe requested review from darionyaphet and dutor May 29, 2019 04:03

## How to contribute to the docs
There are many wats to contribute:
- Edit, rate, or file an issue or question directly on the site by using the links available on the right-side menu on every pare at docs.nebula.com.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs.nebula.com ?

@@ -1,4 +1,3 @@
## Get Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the other .md file's name is upper case . Please rename get-started.md to Get-started.md thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the filename will be showed in the address bar of the browser, lower case might be more suitable, except some special ones, like nGQL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -22,7 +21,11 @@ docker --version

If `docker` is not found, please see [here](https://docs.docker.com/install/) for more information to install docker.

After that, using `docker pull vesoft/nebula-graph:latest` to get `nebula` image and `docker images` that can display images status.
After that, using
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using block is better. :) I like it .

@@ -0,0 +1,101 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the header? I think it's a good habit.

Would you mind adding it to other documents? thanks

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gread work!

I have some comments. Please take a look



## How to contribute to the docs
There are many wats to contribute:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's wats?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a typo, it should ways, thank you


---
## Contribute to documentation
Contributing to the Nebula documentation can be a rewarding experience. When you offer feedback, questions, edits, or new content, you help us, the projects you work on, and the larger Nebula community.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you offer feedback, questions, edits, or new content, you help us, the projects you work on, and the larger Nebula community.

This should be divided into two.

When you offer feedbacks, questions, edits, or new contents, you are helping us.

Besides, what the projects you work on, and the larger Nebula community. is saying?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Means users' feedback can help us improve our Nebula community. Deleted that sentence and add
We welcome your participation to help make the documentation better!

@@ -0,0 +1,16 @@

---
## Contribute to documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename of docs should be all lower case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -1,4 +1,3 @@
## Get Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the filename will be showed in the address bar of the browser, lower case might be more suitable, except some special ones, like nGQL.

docs/how-to-contribute.md Show resolved Hide resolved
dutor
dutor previously approved these changes Jun 5, 2019
@dutor dutor added the ready-for-testing PR: ready for the CI test label Jun 10, 2019
@dutor
Copy link
Contributor

dutor commented Jun 10, 2019

Jenkins, go!

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit d85c160 into vesoft-inc:master Jun 10, 2019
@amber-moe amber-moe deleted the update-docs branch June 11, 2019 02:14
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* update docs to make mkdocs page

* fix Contribute-to-documentation.md info

* fix layout in Contribute-to-documentation.md

* fix typos

* add nGQL-tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants