Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow check god user read from follower #4674

Merged
merged 1 commit into from
Sep 23, 2022
Merged

allow check god user read from follower #4674

merged 1 commit into from
Sep 23, 2022

Conversation

SuperYoko
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://github.com/vesoft-inc/nebula-ent/issues/1319#event-7444097789

Description:

can ready from follower flag not set so that follower alway get a LEADER_CHANGED error when read from kv.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Sep 23, 2022
@SuperYoko
Copy link
Contributor Author

Wait @HarrisChu to put test results.

@HarrisChu
Copy link
Contributor

ok in nmeter

image

@Sophie-Xie Sophie-Xie merged commit dfbbf3d into vesoft-inc:master Sep 23, 2022
@SuperYoko SuperYoko deleted the allow_read_from_follower branch September 28, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants