Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos #4656

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix some typos #4656

merged 2 commits into from
Sep 20, 2022

Conversation

180909
Copy link
Contributor

@180909 180909 commented Sep 18, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@180909 180909 requested a review from critical27 as a code owner September 18, 2022 06:45
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2022

CLA assistant check
All committers have signed the CLA.

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Sep 19, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 84.70% // Head: 84.72% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (ddabccb) compared to base (9c745d5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4656      +/-   ##
==========================================
+ Coverage   84.70%   84.72%   +0.01%     
==========================================
  Files        1358     1358              
  Lines      135632   135643      +11     
==========================================
+ Hits       114892   114921      +29     
+ Misses      20740    20722      -18     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/kvstore/raftex/RaftPart.cpp 69.69% <ø> (-1.33%) ⬇️
src/storage/exec/HashJoinNode.h 94.28% <ø> (ø)
src/storage/test/IndexWriteTest.cpp 99.70% <ø> (ø)
src/common/conf/test/ConfigurationTest.cpp 99.21% <100.00%> (ø)
src/graph/planner/match/StartVidFinder.cpp 87.50% <0.00%> (-5.84%) ⬇️
src/graph/planner/Planner.cpp 75.00% <0.00%> (-5.00%) ⬇️
src/kvstore/wal/WalFileIterator.cpp 64.40% <0.00%> (-4.24%) ⬇️
src/kvstore/raftex/Host.cpp 72.34% <0.00%> (-3.86%) ⬇️
src/kvstore/Part.cpp 53.69% <0.00%> (-2.08%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@critical27 critical27 merged commit 7d5e93f into vesoft-inc:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants