Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry for god user check when leader changed #4643

Merged
merged 4 commits into from
Sep 21, 2022
Merged

add retry for god user check when leader changed #4643

merged 4 commits into from
Sep 21, 2022

Conversation

SuperYoko
Copy link
Contributor

@SuperYoko SuperYoko commented Sep 14, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

#4624

How do you solve it?

retry 3 & raft heart beat time if leader changed.
I didn't handle other info like metaversion/clusterid since it won't affect even rerwite or it has some other logic to get from coding/data structure.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Sophie-Xie
Copy link
Contributor

close #4624

@SuperYoko SuperYoko marked this pull request as ready for review September 20, 2022 07:17
@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Sep 20, 2022
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sophie-Xie Sophie-Xie merged commit f92c24c into vesoft-inc:master Sep 21, 2022
@HarrisChu
Copy link
Contributor

HarrisChu commented Sep 23, 2022

failed in nightly running

image

@SuperYoko SuperYoko deleted the retry_leader_change branch September 28, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants