-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PushFilterDownInnerJoinRule #4599
Conversation
|
||
const Pattern& PushFilterDownInnerJoinRule::pattern() const { | ||
static Pattern pattern = Pattern::create(graph::PlanNode::Kind::kFilter, | ||
{Pattern::create(graph::PlanNode::Kind::kInnerJoin)}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's also workable for LeftJoin, Product.
826004b
to
07c0eaf
Compare
07c0eaf
to
5284d8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #4599 +/- ##
==========================================
+ Coverage 84.72% 84.73% +0.01%
==========================================
Files 1357 1358 +1
Lines 135323 135403 +80
==========================================
+ Hits 114652 114734 +82
+ Misses 20671 20669 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #4525
Description:
add
PushFilterDownInnerJoinRule
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes: