Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PushFilterDownInnerJoinRule #4599

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

caton-hpg
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: #4525

Description:

add PushFilterDownInnerJoinRule

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:


const Pattern& PushFilterDownInnerJoinRule::pattern() const {
static Pattern pattern = Pattern::create(graph::PlanNode::Kind::kFilter,
{Pattern::create(graph::PlanNode::Kind::kInnerJoin)});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's also workable for LeftJoin, Product.

@Sophie-Xie Sophie-Xie requested review from czpmango and dutor August 31, 2022 03:54
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Aug 31, 2022
@caton-hpg caton-hpg requested a review from a team as a code owner September 1, 2022 09:15
@caton-hpg caton-hpg force-pushed the PushFilterDownInnerJoin branch from 826004b to 07c0eaf Compare September 1, 2022 09:20
@caton-hpg caton-hpg force-pushed the PushFilterDownInnerJoin branch from 07c0eaf to 5284d8f Compare September 1, 2022 09:58
Copy link
Contributor

@czpmango czpmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #4599 (4af5890) into master (3157fad) will increase coverage by 0.01%.
The diff coverage is 85.89%.

@@            Coverage Diff             @@
##           master    #4599      +/-   ##
==========================================
+ Coverage   84.72%   84.73%   +0.01%     
==========================================
  Files        1357     1358       +1     
  Lines      135323   135403      +80     
==========================================
+ Hits       114652   114734      +82     
+ Misses      20671    20669       -2     
Impacted Files Coverage Δ
...aph/optimizer/rule/PushFilterDownInnerJoinRule.cpp 85.71% <85.71%> (ø)
src/graph/visitor/FoldConstantExprVisitor.cpp 84.75% <100.00%> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/kvstore/wal/WalFileIterator.cpp 64.40% <0.00%> (-4.24%) ⬇️
src/kvstore/raftex/Host.cpp 72.34% <0.00%> (-3.86%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/storage/exec/FilterNode.h 89.47% <0.00%> (-2.64%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 78.62% <0.00%> (-2.30%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
...c/meta/processors/parts/GetPartsAllocProcessor.cpp 81.66% <0.00%> (-1.67%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dutor dutor merged commit 0a060ff into vesoft-inc:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants