Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve star conversion rate for README #4562

Merged
merged 8 commits into from
Aug 22, 2022
Merged

Conversation

TommyLemon
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: 0

Description: improve star conversion rate

How do you solve it?

Guide viewer the star.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Vue.js 作者尤雨溪:“开源的价值并不是那么容易量化,你不主动去要世界也不会给你。”

为什么Patreon上开源领袖Eric Raymond所得到的捐助不到vue.js的 1/10? - 尤雨溪的回答 - 知乎
https://www.zhihu.com/question/305246119/answer/550207042

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

None.

wey-gu
wey-gu previously approved these changes Aug 22, 2022
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sophie-Xie
Sophie-Xie previously approved these changes Aug 22, 2022
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Aug 22, 2022
@wey-gu
Copy link
Contributor

wey-gu commented Aug 22, 2022

@TommyLemon please put two PR into (this) one, as I just saw your another PR #4561 on en README.

@codecov-commenter
Copy link

Codecov Report

Merging #4562 (4079cc8) into master (9239b32) will increase coverage by 0.00%.
The diff coverage is 73.39%.

@@           Coverage Diff           @@
##           master    #4562   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files        1354     1355    +1     
  Lines      134943   135011   +68     
=======================================
+ Hits       114261   114324   +63     
- Misses      20682    20687    +5     
Impacted Files Coverage Δ
src/graph/executor/query/GetDstBySrcExecutor.cpp 86.20% <0.00%> (-1.52%) ⬇️
src/graph/optimizer/OptGroup.cpp 91.66% <ø> (+0.55%) ⬆️
src/storage/query/GetDstBySrcProcessor.h 100.00% <ø> (ø)
src/storage/query/GetDstBySrcProcessor.cpp 63.68% <40.57%> (-15.27%) ⬇️
src/common/datatypes/Value.cpp 74.39% <80.00%> (-1.06%) ⬇️
...r/rule/RemoveProjectDedupBeforeGetDstBySrcRule.cpp 87.17% <87.17%> (ø)
src/graph/planner/ngql/GoPlanner.cpp 98.84% <89.47%> (-0.45%) ⬇️
src/common/datatypes/DataSet.h 79.46% <100.00%> (+0.18%) ⬆️
src/common/datatypes/List.h 94.54% <100.00%> (+0.20%) ⬆️
src/common/datatypes/Value.h 97.05% <100.00%> (+0.76%) ⬆️
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wey-gu wey-gu changed the title doc: improve star conversion rate for Chinese README doc: improve star conversion rate for README Aug 22, 2022
@TommyLemon TommyLemon dismissed stale reviews from Sophie-Xie and wey-gu via c10eb49 August 22, 2022 07:27
Sophie-Xie
Sophie-Xie previously approved these changes Aug 22, 2022
README.md Outdated

<br />

#### If you like this repo, or it can help you, please ⭐️ Star it at the top right corner~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If to put it in en README, too, I would word it as.

-#### If you like this repo, or it can help you, please ⭐️ Star it at the top right corner~ 
+#### If you find NebulaGraph interesting, please star us on GitHub ⭐️.

README.md Outdated

<br />

#### If you find NebulaGraph interesting, please ⭐️ Star it on GitHub at top right corner
Copy link
Contributor

@wey-gu wey-gu Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to not mention the top right corner as we cannot assume everyone is visiting this readme in a non-mobile browser/non-GitHub mobile client(especially for global visitors).

Screen Shot 2022-08-22 at 4 04 46 PM

Copy link
Contributor Author

@TommyLemon TommyLemon Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it does be an issue. It's important to guide visitors star the project in a easy way.

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Sophie-Xie Sophie-Xie merged commit c884477 into master Aug 22, 2022
@Sophie-Xie Sophie-Xie deleted the TommyLemon-patch-2 branch August 22, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants