-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: improve star conversion rate for README #4562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤
@TommyLemon please put two PR into (this) one, as I just saw your another PR #4561 on en README. |
Codecov Report
@@ Coverage Diff @@
## master #4562 +/- ##
=======================================
Coverage 84.67% 84.67%
=======================================
Files 1354 1355 +1
Lines 134943 135011 +68
=======================================
+ Hits 114261 114324 +63
- Misses 20682 20687 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
README.md
Outdated
|
||
<br /> | ||
|
||
#### If you like this repo, or it can help you, please ⭐️ Star it at the top right corner~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If to put it in en README, too, I would word it as.
-#### If you like this repo, or it can help you, please ⭐️ Star it at the top right corner~
+#### If you find NebulaGraph interesting, please star us on GitHub ⭐️.
README.md
Outdated
|
||
<br /> | ||
|
||
#### If you find NebulaGraph interesting, please ⭐️ Star it on GitHub at top right corner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it does be an issue. It's important to guide visitors star the project in a easy way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: 0
Description: improve star conversion rate
How do you solve it?
Guide viewer the star.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Vue.js 作者尤雨溪:“开源的价值并不是那么容易量化,你不主动去要世界也不会给你。”
为什么Patreon上开源领袖Eric Raymond所得到的捐助不到vue.js的 1/10? - 尤雨溪的回答 - 知乎
https://www.zhihu.com/question/305246119/answer/550207042
Checklist:
Tests:
Affects:
Release notes:
None.