Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser2 #4478

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Parser2 #4478

merged 3 commits into from
Aug 2, 2022

Conversation

peter-rich
Copy link

@peter-rich peter-rich commented Aug 2, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description: Parser and Test

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@peter-rich peter-rich requested a review from dutor as a code owner August 2, 2022 08:53
@peter-rich peter-rich merged commit 1e58ada into vesoft-inc:release-3.2-subgraphmatch Aug 2, 2022
@wey-gu wey-gu mentioned this pull request Aug 6, 2022
Closed
wenhaocs
wenhaocs reviewed Aug 14, 2022
View reviewed changes
Copy link
Contributor

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please discuss it with me.

src/parser/TraverseSentences.h
class IsomorSentence final : public Sentence {
public:
explicit IsomorSentence(NameLabelList* tags) {
tags_.reset(tags);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you take tags as input for isomor sentence? Shouldn't it be space name？

src/parser/parser.yy


isomor_sentence
: KW_ISOMOR name_label_list {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you only take one argument? Shouldn't it be 2 arguments?

This was linked to issues Aug 17, 2022
Parser() #4540
Closed
Test Parser #4547
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenhaocs wenhaocs wenhaocs left review comments

@dutor dutor Awaiting requested review from dutor dutor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Parser Parser()
2 participants
@peter-rich @wenhaocs