-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong image path for architecture #4471
Conversation
the original image path "https://github.com/vesoft-inc/nebula-docs/raw/master/images/Nebula%20Arch.png" is outdated and cannot be loaded by browsers. I used the image path for architecture from English README as a replacement.
Thanks for contribution. |
@TommyLemon Thanks! Please use this stable URL: |
@randomJoe211 Hi, I've already changed the architecture image path with the url you gave me: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## master #4471 +/- ##
==========================================
+ Coverage 84.56% 84.68% +0.12%
==========================================
Files 1344 1346 +2
Lines 134121 134256 +135
==========================================
+ Hits 113414 113701 +287
+ Misses 20707 20555 -152
Continue to review full report at Codecov.
|
@TommyLemon Thanks! pls sign the CLA, otherwise I can't merge. |
@Sophie-Xie ok, I've already signed the CLA |
the original image path "https://github.com/vesoft-inc/nebula-docs/raw/master/images/Nebula%20Arch.png" is outdated and cannot be loaded by browsers.
https://github.com/vesoft-inc/nebula/blob/master/README-CN.md
I used the image path for architecture from English README as a replacement.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Replace with the image path from English README.md
And now it can show the image.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe:
Fixed image loading error for Chinese README.md