-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job manager related fix #4446
Job manager related fix #4446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
future.wait(); | ||
if (!future.value().ok()) { | ||
LOG(INFO) << future.value().toString(); | ||
rc = nebula::cpp2::ErrorCode::E_ADD_JOB_FAILURE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, all failed jobs will return the same error code. Which issue # is this related to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
@critical27 pls fix the tck. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4247
#4232 (Part of the issue is addressed in #4444)
https://github.com/vesoft-inc/nebula-ent/issues/1052
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: