Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job manager related fix #4446

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Job manager related fix #4446

merged 5 commits into from
Jul 22, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Jul 20, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4247
#4232 (Part of the issue is addressed in #4444)
https://github.com/vesoft-inc/nebula-ent/issues/1052

Description:

  1. When stop job a failed/finished job, we will return "E_SAVE_JOB_FAILURE" , which is obscure, return another error code.
  2. Balance leader/data's error code is not passed out. And balance leader has no tasks, which is quite same as fix download always return succeeded #4442

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 requested a review from a team as a code owner July 20, 2022 08:47
@critical27 critical27 changed the title Fix Fix error message when failed a stop/finish job, and balance leader error code is wrong Jul 20, 2022
@critical27 critical27 added ready-for-testing PR: ready for the CI test ready for review labels Jul 20, 2022
liwenhui-soul
liwenhui-soul previously approved these changes Jul 20, 2022
@critical27 critical27 changed the title Fix error message when failed a stop/finish job, and balance leader error code is wrong Job manager related fix Jul 20, 2022
wenhaocs
wenhaocs previously approved these changes Jul 21, 2022
Copy link
Contributor

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

future.wait();
if (!future.value().ok()) {
LOG(INFO) << future.value().toString();
rc = nebula::cpp2::ErrorCode::E_ADD_JOB_FAILURE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, all failed jobs will return the same error code. Which issue # is this related to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Sophie-Xie
Copy link
Contributor

@critical27 pls fix the tck.

@critical27 critical27 dismissed stale reviews from panda-sheep and wenhaocs via 09f8928 July 21, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc done PR:the doc for this PR is done. ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants