Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid folly::init overwirte log configuration. #4443

Merged

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Jul 19, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Avoid folly::init overwirte the glog configuration.

How do you solve it?

Patch of #4409

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Jul 19, 2022
@Shylock-Hg Shylock-Hg requested a review from a team as a code owner July 19, 2022 09:29
@@ -66,12 +66,7 @@ int main(int argc, char* argv[]) {
// the 2nd will make the 1st failed to output log anymore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify if the behavior in the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In current folly::init and SetUpLogging is called after pid checking too.

Copy link
Contributor Author

@Shylock-Hg Shylock-Hg Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But Standalone daemon and Graphd daemon don't require this constraint even before this PR, need to modify it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok for now. I can't clearly remember why we move setupLogging very close to start position of the main.

@Shylock-Hg Shylock-Hg requested a review from critical27 July 20, 2022 02:13
@critical27 critical27 merged commit 7d83ac6 into vesoft-inc:master Jul 20, 2022
@Shylock-Hg Shylock-Hg deleted the fix/folly-init-overwirte-log-conf branch July 20, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants