-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid folly::init overwirte log configuration. #4443
Avoid folly::init overwirte log configuration. #4443
Conversation
@@ -66,12 +66,7 @@ int main(int argc, char* argv[]) { | |||
// the 2nd will make the 1st failed to output log anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify if the behavior in the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In current folly::init
and SetUpLogging
is called after pid checking too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But Standalone daemon and Graphd daemon don't require this constraint even before this PR, need to modify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok for now. I can't clearly remember why we move setupLogging
very close to start position of the main.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Avoid folly::init overwirte the glog configuration.
How do you solve it?
Patch of #4409
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: