Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4407, building failures with tests on #4414

Merged
merged 4 commits into from
Jul 21, 2022

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Jul 13, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4407

Description:

See #4407

How do you solve it?

(1) convert character sequences into std::string to avoid string-overread or array-out-of-bound errors reported by the compiler.
(2) add missing header files in some tests to fix 'undefined references' errors.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Jul 14, 2022
@Sophie-Xie Sophie-Xie requested review from dutor and jievince July 14, 2022 02:42
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #4414 (10f4dbb) into master (7981108) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4414      +/-   ##
==========================================
+ Coverage   84.54%   84.65%   +0.11%     
==========================================
  Files        1345     1345              
  Lines      134030   134057      +27     
==========================================
+ Hits       113314   113488     +174     
+ Misses      20716    20569     -147     
Impacted Files Coverage Δ
src/common/datatypes/test/ValueTest.cpp 98.94% <ø> (ø)
...rc/common/graph/tests/ResponseEncodeDecodeTest.cpp 100.00% <ø> (ø)
src/common/base/ICord.h 91.15% <100.00%> (+0.15%) ⬆️
src/common/expression/ColumnExpression.cpp 95.45% <100.00%> (+50.00%) ⬆️
...rc/common/expression/test/ColumnExpressionTest.cpp 100.00% <100.00%> (ø)
src/storage/exec/IndexNode.cpp 91.66% <0.00%> (-8.34%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/common/geo/io/wkb/WKBReader.cpp 94.11% <0.00%> (-2.27%) ⬇️
src/graph/optimizer/Optimizer.cpp 91.52% <0.00%> (-1.70%) ⬇️
src/common/expression/LogicalExpression.cpp 91.89% <0.00%> (-1.69%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930afc1...10f4dbb. Read the comment docs.

@Sophie-Xie Sophie-Xie added this to the v3.3.0 milestone Jul 18, 2022
dutor
dutor previously approved these changes Jul 18, 2022
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a confirmed false positive bug introduced since GCC 11. I'm not sure whether this change can actually suppress the warning. But we will see.

jievince
jievince previously approved these changes Jul 18, 2022
@xtcyclist xtcyclist dismissed stale reviews from jievince and dutor via 453c865 July 18, 2022 08:00
@xtcyclist xtcyclist force-pushed the fix_4407 branch 2 times, most recently from 453c865 to 79fda1d Compare July 18, 2022 08:05
@xtcyclist xtcyclist changed the title Fix #4407 that blocks building with '-DENABLE_TESTING=ON' Fix multiple issues with tests Jul 18, 2022
@xtcyclist xtcyclist force-pushed the fix_4407 branch 2 times, most recently from 0d718ef to 10f4dbb Compare July 18, 2022 08:51
@xtcyclist
Copy link
Contributor Author

xtcyclist commented Jul 18, 2022

Tried to fix #4425, #4426, #4427 and #4428 altogether by reordering the properties in the test cases which cause wrong comparision results. But the order of properties responseded by the clang-compiled version differ from those gcc-compiled versions, although all of them are correct. So, giving up altering the test cases in this PR. Looking for other ways to fix.

This PR is now the same with the previously reviewed version.

@xtcyclist xtcyclist requested review from dutor and jievince July 18, 2022 08:55
@xtcyclist xtcyclist changed the title Fix multiple issues with tests Fix #4407, building failures with tests on Jul 18, 2022
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Sophie-Xie Sophie-Xie merged commit 4ed8da4 into vesoft-inc:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants