-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4407, building failures with tests on #4414
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4414 +/- ##
==========================================
+ Coverage 84.54% 84.65% +0.11%
==========================================
Files 1345 1345
Lines 134030 134057 +27
==========================================
+ Hits 113314 113488 +174
+ Misses 20716 20569 -147
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a confirmed false positive bug introduced since GCC 11. I'm not sure whether this change can actually suppress the warning. But we will see.
453c865
to
79fda1d
Compare
0d718ef
to
10f4dbb
Compare
Tried to fix #4425, #4426, #4427 and #4428 altogether by reordering the properties in the test cases which cause wrong comparision results. But the order of properties responseded by the clang-compiled version differ from those gcc-compiled versions, although all of them are correct. So, giving up altering the test cases in this PR. Looking for other ways to fix. This PR is now the same with the previously reviewed version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4407
Description:
See #4407
How do you solve it?
(1) convert character sequences into std::string to avoid string-overread or array-out-of-bound errors reported by the compiler.
(2) add missing header files in some tests to fix 'undefined references' errors.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: