-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ColumnExpression encode and decode are not matched #4413
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4413 +/- ##
==========================================
+ Coverage 84.53% 84.62% +0.08%
==========================================
Files 1345 1345
Lines 134046 134045 -1
==========================================
+ Hits 113318 113435 +117
+ Misses 20728 20610 -118
Continue to review full report at Codecov.
|
@@ -34,7 +34,7 @@ void ColumnExpression::accept(ExprVisitor *visitor) { | |||
|
|||
void ColumnExpression::writeTo(Encoder &encoder) const { | |||
encoder << kind_; | |||
encoder << index_; | |||
encoder << Value(index_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReadSize in decoder is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
please review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4412
Description:
How do you solve it?
Let ColumnExpression writeTo encoder via
Value
instead ofsize_t
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: