fix_shortest_path_crash #4352
Merged
fix_shortest_path_crash #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
added
ready-for-testing
Shylock-Hg
reviewed
Jun 24, 2022
| @@ -86,6 +80,7 @@ class ShortestPathBase { | |||
| std::unordered_map<std::string, std::string>* stats_{nullptr}; | |||
| size_t maxStep_; | |||
| bool singleShortest_{true}; | |||
| folly::SpinLock statsLock_; | |||
There was a problem hiding this comment.
How about other members?
There was a problem hiding this comment.
other members will not be written by multiple threads at the same time
Shylock-Hg
reviewed
Jun 24, 2022
| @@ -264,6 +264,9 @@ folly::Future<bool> SingleShortestPath::buildEvenPath(size_t rowNum, | |||
| return false; | |||
| } | |||
| for (auto& meetVertex : vertices) { | |||
| if (!meetVertex.isVertex()) { | |||
There was a problem hiding this comment.
vertices may contain EMPTY values in exceptional cases
Aiee
approved these changes
Jun 24, 2022
Shylock-Hg
approved these changes
Jun 24, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Jun 27, 2022
* force cache the docker layer (#4331) * check god role exist when meta init (#4330) * check god role exist when meta init * return error if kv fail Co-authored-by: Doodle <[email protected]> * Fix object pool mtsafe. (#4332) * Fix object pool mtsafe. * Fix lock. * Fixed web service crash (#4334) Co-authored-by: Sophie <[email protected]> * Fix get edges transform rule. (#4328) 1. Input/Ouput variables. 2. Keep column names of Limit same with input plan node. Co-authored-by: Sophie <[email protected]> * fix rc docker (#4336) * add lock (#4352) * fix map concurrency issue (#4344) * fix mutex in map * add test * move the order Co-authored-by: Sophie <[email protected]> * add stats under index conditions (#4353) Co-authored-by: Harris.Chu <[email protected]> Co-authored-by: jimingquan <[email protected]> Co-authored-by: Doodle <[email protected]> Co-authored-by: shylock <[email protected]> Co-authored-by: dutor <[email protected]> Co-authored-by: panda-sheep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Graph crash when running tck manually
Can't be reproduced consistently.
Tck is run with 16 concurrent threads.
How do you solve it?
shared variables are locked before use in multi-threading environment
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: