Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate vid predication Filter. #4249

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented May 11, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Sub job of #4122

Description:

GetVertices will retrieve Vertex by Id set directly, so we don't filter them again in Filter operator, so we eliminate this Filter operator.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added type/enhancement Type: make the code neat or more efficient ready-for-testing PR: ready for the CI test labels May 11, 2022
@Shylock-Hg Shylock-Hg added this to the v3.2.0 milestone May 11, 2022
@nevermore3
Copy link
Contributor

if the vertexIDSeek statement is mixed with other property filtering statements, can we delete the vertexID condition after selecting the vertexID index?

@Shylock-Hg
Copy link
Contributor Author

if the vertexIDSeek statement is mixed with other property filtering statements, can we delete the vertexID condition after selecting the vertexID index?

We can, but need to refactor VidExtractVisitor and maybe lead to incompatible, so don't refactor it here.

nevermore3
nevermore3 previously approved these changes May 11, 2022
Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remove the debug logs.

src/graph/util/ExpressionUtils.cpp Outdated Show resolved Hide resolved
@Sophie-Xie Sophie-Xie merged commit 2a1ce0f into vesoft-inc:master May 12, 2022
@Shylock-Hg Shylock-Hg deleted the optimize/eliminate-vid-predication-Filter branch May 12, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants