-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate vid predication Filter. #4249
Eliminate vid predication Filter. #4249
Conversation
…m:Shylock-Hg/nebula into optimize/eliminate-vid-predication-Filter
if the vertexIDSeek statement is mixed with other property filtering statements, can we delete the vertexID condition after selecting the vertexID index? |
We can, but need to refactor VidExtractVisitor and maybe lead to incompatible, so don't refactor it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please remove the debug logs.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Sub job of #4122
Description:
GetVertices will retrieve Vertex by Id set directly, so we don't filter them again in Filter operator, so we eliminate this Filter operator.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: