Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_predicate_in_where #4248

Closed
wants to merge 5 commits into from
Closed

fix_predicate_in_where #4248

wants to merge 5 commits into from

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented May 11, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #4241

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected ready for review labels May 11, 2022
@nevermore3 nevermore3 changed the title Start end contain fix_predicate_in_where May 11, 2022
@nevermore3 nevermore3 force-pushed the start_end_contain branch from 1715c2c to afe2c0b Compare May 11, 2022 07:33
@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone May 11, 2022
@nevermore3 nevermore3 added the need to discuss Solution: issue or PR without a clear conclusion on whether to handle it label May 11, 2022
czpmango
czpmango reviewed May 14, 2022
View reviewed changes
src/common/expression/RelationalExpression.cpp
@@ -113,82 +113,70 @@ const Value& RelationalExpression::eval(ExpressionContext& ctx) {
break;
}
case Kind::kContains: {
if (lhs.isBadNull() || rhs.isBadNull()) {
result_ = Value::kNullBadType;
} else if ((!lhs.isNull() && !lhs.isStr()) || (!rhs.isNull() && !rhs.isStr())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

return "czp " contains 3;

@Sophie-Xie Sophie-Xie removed the request for review from yixinglu June 6, 2022 02:30
@nevermore3 nevermore3 closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czpmango czpmango czpmango left review comments

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@Shylock-Hg Shylock-Hg Awaiting requested review from Shylock-Hg

Assignees
No one assigned
Labels
need to discuss Solution: issue or PR without a clear conclusion on whether to handle it ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

More expressions in prop filtering for GO
3 participants
@nevermore3 @czpmango @Sophie-Xie