Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetNeighborsIter could get size now. #4240

Merged

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented May 9, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label May 9, 2022
@Shylock-Hg Shylock-Hg added this to the v3.2.0 milestone May 9, 2022
@Shylock-Hg Shylock-Hg requested review from CPWstatic and nevermore3 May 9, 2022 03:41
@codecov-commenter
Copy link

Codecov Report

Merging #4240 (cca71c6) into master (1fd89af) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4240      +/-   ##
==========================================
+ Coverage   84.89%   84.96%   +0.07%     
==========================================
  Files        1326     1326              
  Lines      131806   131803       -3     
==========================================
+ Hits       111892   111991      +99     
+ Misses      19914    19812     -102     
Impacted Files Coverage Δ
src/graph/executor/Executor.cpp 81.23% <100.00%> (+0.51%) ⬆️
src/graph/executor/StorageAccessExecutor.cpp 100.00% <100.00%> (ø)
src/graph/executor/query/ProjectExecutor.cpp 100.00% <100.00%> (ø)
src/graph/executor/query/GetPropExecutor.h 82.35% <0.00%> (-5.89%) ⬇️
src/kvstore/raftex/Host.cpp 72.34% <0.00%> (-3.22%) ⬇️
src/graph/executor/StorageAccessExecutor.h 62.22% <0.00%> (-2.23%) ⬇️
src/graph/optimizer/Optimizer.cpp 91.52% <0.00%> (-1.70%) ⬇️
src/codec/RowReaderWrapper.h 95.08% <0.00%> (-1.59%) ⬇️
src/common/network/NetworkUtils.cpp 80.89% <0.00%> (-0.57%) ⬇️
src/kvstore/Listener.cpp 78.52% <0.00%> (-0.36%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd89af...cca71c6. Read the comment docs.

@Sophie-Xie Sophie-Xie merged commit 00d5b6b into vesoft-inc:master May 12, 2022
@Shylock-Hg Shylock-Hg deleted the enhancement/fit-GetNeighborsIter-size branch May 12, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants