Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lookup crash when has nullable cols #4234

Merged
merged 1 commit into from
May 6, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented May 6, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4230

Description:

The main problem has two parts:

  1. The indexNullable_ in IndexScanNode is not initialized correctly.
  2. In IndexScanNode, the offset of nullable bits is not calculated correctly.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Check if there is an nullable property when build plan.

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:
Fix storage may crash when lookup index with nullable property.

@Sophie-Xie Sophie-Xie merged commit 1fd89af into vesoft-inc:master May 6, 2022
@critical27 critical27 deleted the fix branch May 6, 2022 08:26
@Sophie-Xie Sophie-Xie added the affects/v3.1 PR/issue: this bug affects v3.1.x version. label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/v3.1 PR/issue: this bug affects v3.1.x version. ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants