modify subgraph loop condition #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
added
type/enhancement
czpmango
reviewed
May 5, 2022
Comment on lines
+74
to
+82
| uint32_t maxSteps = steps.steps(); | ||
| if (subgraphCtx_->getEdgeProp || subgraphCtx_->withProp) { | ||
| ++maxSteps; | ||
| } |
There was a problem hiding this comment.
Why does taking properties have to do with the max step of loop.
There was a problem hiding this comment.
getEdgeProp just indicates whether to output the edge。will fix name, avoid ambiguity
nevermore3
force-pushed
the
subgraph_vertices
branch
from
fe973bf to
c1b9462
Compare
Shylock-Hg
reviewed
May 5, 2022
| if (subgraphCtx_->getEdgeProp || subgraphCtx_->withProp) { | ||
| ++maxSteps; | ||
| } | ||
| auto* condition = loopCondition(maxSteps, gn->outputVar()); |
There was a problem hiding this comment.
Steps of subgraph executor don't keep same with this?
Shylock-Hg
approved these changes
May 5, 2022
czpmango
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
The last step of the subgraph is to get all the edges between the visited vetices, if only the output vertices, do not need to take the last step
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: