Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check maximum length of variable length relationship #4200

Closed
wants to merge 2 commits into from

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Apr 22, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review labels Apr 22, 2022
@Shylock-Hg
Copy link
Contributor

It's modified in #3881

@nevermore3
Copy link
Contributor Author

nevermore3 commented Apr 22, 2022

#3881

this PR removes the limit of maximum length, there is a risk of OOM

@Shylock-Hg
Copy link
Contributor

#3881

this PR removes the limit of maximum length, there is a risk of OOM

We should avoid OOM by memory tacking and kill expensive query.

@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone Apr 25, 2022
@nevermore3 nevermore3 closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants