Move input rows of Traverse and AppendVertices. #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4176 +/- ##
==========================================
- Coverage 84.99% 84.94% -0.05%
==========================================
Files 1326 1326
Lines 131713 131770 +57
==========================================
- Hits 111946 111936 -10
- Misses 19767 19834 +67
Continue to review full report at Codecov.
|
nevermore3
reviewed
May 19, 2022
| @@ -682,6 +682,27 @@ void Executor::dropBody(const PlanNode *body) { | |||
| } | |||
| } | |||
|
|
|||
| bool Executor::movable(const Variable *var) { | |||
| // Only support input variables of current executor | |||
There was a problem hiding this comment.
what if the data flow and logical flow are different, such as bfsShortestPath operator
There was a problem hiding this comment.
We use reference count to identify it.
nevermore3
approved these changes
May 19, 2022
CPWstatic
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #4172
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: