Add init of GraphService and check it #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangleptr
reviewed
May 22, 2019
src/common/network/NetworkUtils.cpp
Outdated
| @@ -230,6 +230,9 @@ StatusOr<HostAddr> NetworkUtils::toHostAddr(folly::StringPiece ipPort) { | |||
| } | |||
|
|
|||
| StatusOr<std::vector<HostAddr>> NetworkUtils::toHosts(const std::string& peersStr) { | |||
| if (peersStr.empty()) { | |||
There was a problem hiding this comment.
I think we should NOT forbid empty peersStr.
Because in some cases, we actually pass in empty string.
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
dangleptr
reviewed
May 23, 2019
src/graph/ExecutionEngine.cpp
Outdated
| @@ -25,9 +25,10 @@ ExecutionEngine::~ExecutionEngine() { | |||
|
|
|||
| Status ExecutionEngine::init(std::shared_ptr<folly::IOThreadPoolExecutor> ioExecutor) { | |||
| auto addrs = network::NetworkUtils::toHosts(FLAGS_meta_server_addrs); | |||
| if (!addrs.ok()) { | |||
| if (!addrs.ok() || addrs.value().empty()) { | |||
There was a problem hiding this comment.
If FLAGS_meta_server_addrs is not empty, in which case "toHosts" return empty array?
whitewum
reviewed
Jun 12, 2019
src/graph/test/TestEnv.cpp
Outdated
| @@ -28,7 +28,11 @@ void TestEnv::SetUp() { | |||
| using ThriftServer = apache::thrift::ThriftServer; | |||
| server_ = std::make_unique<ThriftServer>(); | |||
| server_->getIOThreadPool()->setNumThreads(1); | |||
There was a problem hiding this comment.
what about multiple threads tests?
|
Unit testing passed. |
whitewum
previously approved these changes
Jun 19, 2019
|
Unit testing failed. |
dutor
previously approved these changes
Jun 28, 2019
|
Unit testing passed. |
Closed
|
the pr is so long time, close it |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* Add session context definition * Add local seesion command * Add show local queries command and depracate show all queries * Fix ut * Fix pytest * Add tck case * Save multiple sessions in the cluster fixture in TCK * Add tck case * Format Co-authored-by: Yichen Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #557