Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker image version (typo) #4087

Merged
merged 2 commits into from
Mar 28, 2022
Merged

fix docker image version (typo) #4087

merged 2 commits into from
Mar 28, 2022

Conversation

Sophie-Xie
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4080

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

None

@Sophie-Xie Sophie-Xie closed this Mar 28, 2022
@Sophie-Xie Sophie-Xie deleted the Sophie-Xie-patch-1 branch March 28, 2022 06:07
@Sophie-Xie Sophie-Xie restored the Sophie-Xie-patch-1 branch March 28, 2022 06:15
@Sophie-Xie Sophie-Xie reopened this Mar 28, 2022
@HarrisChu
Copy link
Contributor

fix 2:
if compile error, and then it would run command after ||

@Sophie-Xie Sophie-Xie requested a review from CPWstatic March 28, 2022 07:43
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Mar 28, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Mar 28, 2022
@Sophie-Xie Sophie-Xie merged commit 9255df2 into master Mar 28, 2022
@Sophie-Xie Sophie-Xie deleted the Sophie-Xie-patch-1 branch March 28, 2022 08:25
HarrisChu added a commit that referenced this pull request Mar 28, 2022
* fix docker image version

* fix package command

Co-authored-by: HarrisChu <[email protected]>
Sophie-Xie added a commit that referenced this pull request Mar 28, 2022
* fix docker image version

* fix package command

Co-authored-by: HarrisChu <[email protected]>

Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants