Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
There are many cases that storage can't exit gracefully, we may stuck forever or just crash... There are several reason:
kvstore
,RaftPart
,TaskManager
,MetaClient
, the thread pool is the same one in rpc server. And the relationship between them could be quite complicated.How do you solve it?
setup
/cleanUp
, instead of callingserve
/stop
. In short words, when we callstop
,serve
will be out of scope, andcleanUp
will be triggered. If we concurrently callstop
of several ThriftServer, we may crash because the thread pool are shared.setup
/cleanUp
, we don't need the extra thread to wait forever, all of them are deleted in this PR.As for point 1, the explanation is quite simple above, there are some points:
stopAcceptingAndJoinOutstandingRequests
,stopCPUWorkers
,stopWorkers
stopWorkersOnStopListening_
andjoinRequestsWhenServerStops_
) which will impact when the three function above be called (they will be called either incleanUp
or~ThriftServer
or both...).Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe:
Not only introduced in this version, not related.