Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use STL facilities instead of 3rd party libraries #4030

Merged
merged 21 commits into from
Mar 16, 2022
Merged

refactor: use STL facilities instead of 3rd party libraries #4030

merged 21 commits into from
Mar 16, 2022

Conversation

jiayuehua
Copy link
Contributor

Signed-off-by: Jun [email protected]

What type of PR is this?

  • bug
  • feature
  • [*] enhancement

What problem(s) does this PR solve?

Issue(s) number:

#3198

Description:

How do you solve it?

base on #3200, then modify new code.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

junaire and others added 12 commits October 25, 2021 14:29
@junaire
refactor: use std::any instead of boost::any
b667a7f 
Signed-off-by: Jun <[email protected]>
@junaire
refactor: use std::variant instead of boost::variant
f1148aa 
Signed-off-by: Jun <[email protected]>
@junaire
refactor: use std::optional instead of folly::optional
f382099 
Signed-off-by: Jun <[email protected]>
@junaire
refactor: replace folly::none with std::nullopt
f0c312b 
Signed-off-by: Jun <[email protected]>
@junaire
refactor: use std::get instead of boost::get
e82e23d 
Signed-off-by: Jun <[email protected]>
@junaire
refactor: use std::optional instead of boost::optional
b24a7a2 
Signed-off-by: Jun <[email protected]>
@junaire
refactor: correct std::optional api to has_value()
ef96400 
Signed-off-by: Jun <[email protected]>
@junaire
refactor: correct std::variant api
fb8e64e 
Signed-off-by: Jun <[email protected]>
@junaire
fix: add default parameters
668cba6 
Signed-off-by: Jun <[email protected]>
@junaire
fix: convert folly::Optional to std::optional
b578abf 
Signed-off-by: Jun <[email protected]>
@jiayuehua
Merge remote-tracking branch 'upstream/master' into cxx-standard
04306ef
@jiayuehua
format files
c47b596
@jiayuehua jiayuehua requested review from yixinglu and czpmango March 15, 2022 04:58
@jiayuehua jiayuehua changed the title refactor: use std::any instead of boost::any refactor: use STL facilities instead of 3rd party libraries Mar 15, 2022
Shylock-Hg
Shylock-Hg previously approved these changes Mar 15, 2022
View reviewed changes
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Mar 15, 2022
Aiee
Aiee previously approved these changes Mar 15, 2022
View reviewed changes
Shylock-Hg
Shylock-Hg previously approved these changes Mar 15, 2022
View reviewed changes
critical27
critical27 previously approved these changes Mar 15, 2022
View reviewed changes
@Sophie-Xie Sophie-Xie removed the request for review from czpmango March 15, 2022 12:58
@jiayuehua jiayuehua dismissed stale reviews from critical27 and Shylock-Hg via 23bf0e4 March 16, 2022 03:28
zhaohaifei
zhaohaifei approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@zhaohaifei zhaohaifei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sophie-Xie Sophie-Xie merged commit a57acd0 into vesoft-inc:master Mar 16, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Mar 19, 2022
Closed
@jiayuehua jiayuehua deleted the cxx-standard branch March 22, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohaifei zhaohaifei zhaohaifei approved these changes

@critical27 critical27 critical27 approved these changes

@CPWstatic CPWstatic CPWstatic approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg left review comments

@Aiee Aiee Aiee left review comments

@sherman-the-tank sherman-the-tank Awaiting requested review from sherman-the-tank

@yixinglu yixinglu Awaiting requested review from yixinglu

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jiayuehua @CPWstatic @critical27 @Aiee @zhaohaifei @Shylock-Hg @Sophie-Xie @junaire @yixinglu