cleanWal by commitLogId #4015
Merged
cleanWal by commitLogId #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
requested review from
critical27 and
sherman-the-tank
as code owners
critical27
reviewed
Mar 14, 2022
| @@ -1133,7 +1133,7 @@ void NebulaStore::cleanWAL() { | |||
| auto& part = partEntry.second; | |||
| if (part->needToCleanWal()) { | |||
| // clean wal by expired time | |||
| part->wal()->cleanWAL(); | |||
| part->cleanWal(); | |||
There was a problem hiding this comment.
Maybe unify all usage, either implement cleanWAL() in Part and Listener, or just call part->wal()->cleanWAL(id).
critical27
reviewed
Mar 14, 2022
| // clean wal by log id | ||
| listener->wal()->cleanWAL(listener->getApplyId()); | ||
| // clean wal by commit log id | ||
| listener->cleanWal(); |
There was a problem hiding this comment.
Listener need to override it, because it use apply id, not commitId
pengweisong
reviewed
Mar 15, 2022
| // remove wal file that lastId is less than target | ||
| auto iter = walFiles_.begin(); | ||
| while (iter != walFiles_.end()) { | ||
| if (iter->second->lastId() < id) { | ||
| if (iter->second->lastId() < id && index < size - 2 && (now - iter->second->mtime() > walTTL)) { |
There was a problem hiding this comment.
If we do not use walTTL to limit the cleanWAL, what will happen?
There was a problem hiding this comment.
Then no wal would be deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: