show peers in raft stat #4014
Merged
show peers in raft stat #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
requested review from
a team,
critical27 and
sherman-the-tank
as code owners
critical27
approved these changes
Mar 14, 2022
| @@ -133,6 +133,7 @@ struct GetStateResponse { | |||
| 6: LogID last_log_id; | |||
| 7: TermID last_log_term; | |||
| 8: Status status; | |||
| 9: list<binary> peers; | |||
There was a problem hiding this comment.
peers have been used?
There was a problem hiding this comment.
what used mean?
There was a problem hiding this comment.
where is the use of it
There was a problem hiding this comment.
monitor tools
There was a problem hiding this comment.
Maybe you could add some context or explanation in the future pr
There was a problem hiding this comment.
It's very important for us to retrieve raft peers info when troubleshooting raft issues.
BTW, think we should also include this info in storage monitring metrics.
pengweisong
reviewed
Mar 15, 2022
| @@ -1067,6 +1067,15 @@ void RaftPart::getState(cpp2::GetStateResponse& resp) { | |||
| resp.last_log_id_ref() = lastLogId_; | |||
| resp.last_log_term_ref() = lastLogTerm_; | |||
| resp.status_ref() = status_; | |||
| std::vector<std::string> peers; | |||
There was a problem hiding this comment.
Is the peers containing itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: