-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary pack script opt #4010
Binary pack script opt #4010
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#!/bin/bash | ||
|
||
install_dir=/usr/local/nebula | ||
daemons=(storaged metad graphd) | ||
for daemon in ${daemons[@]} | ||
do | ||
if [[ ! -f $install_dir/scripts/nebula.service ]] ; then | ||
$install_dir/scripts/nebula.service stop ${daemon} | ||
fi | ||
done |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#!/bin/bash | ||
|
||
daemons=(storaged metad graphd) | ||
for daemon in ${daemons[@]} | ||
do | ||
if [[ ! -f $RPM_INSTALL_PREFIX/scripts/nebula.service ]] ; then | ||
$RPM_INSTALL_PREFIX/scripts/nebula.service stop ${daemon} | ||
fi | ||
done |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,6 +141,8 @@ function start_daemon { | |
local command="${executable} --flagfile ${config}" | ||
INFO "Starting ${daemon_name}..." | ||
eval ${command} | ||
local port=$(get_port_from_config ${config}) | ||
wait_for_port_listening ${port} 20 || WARN "Timed out waiting for ${daemon_name} to finish starting, but it may still be running" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prefer to implement this logic in nebula process. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or just like readinessprobe in k8s, curl a http interface? |
||
INFO "Done" | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This operation can be dangerous in a production environment. I suggest that we do not do this implicitly.