Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate download and ingest into job manager #3994

Merged
merged 3 commits into from
Mar 29, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove some useless flag
darionyaphet committed Mar 29, 2022
commit e51f9c3027d217d74648b2e7ca506fd585634f18
2 changes: 1 addition & 1 deletion src/daemons/MetaDaemonInit.cpp
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ DEFINE_int32(meta_num_io_threads, 16, "Number of IO threads");
DEFINE_int32(meta_num_worker_threads, 32, "Number of workers");
DEFINE_string(meta_data_path, "", "Root data path");
DECLARE_string(meta_server_addrs); // use define from grap flags.
DECLARE_int32(ws_meta_http_port);
DEFINE_int32(ws_meta_http_port, 11000, "Port to listen on Meta with HTTP protocol");
#endif

using nebula::web::PathParams;
2 changes: 0 additions & 2 deletions src/meta/http/test/MetaHttpReplaceHandlerTest.cpp
Original file line number Diff line number Diff line change
@@ -16,8 +16,6 @@
#include "webservice/Router.h"
#include "webservice/WebService.h"

DECLARE_int32(ws_storage_http_port);

namespace nebula {
namespace meta {

2 changes: 0 additions & 2 deletions src/meta/test/JobManagerTest.cpp
Original file line number Diff line number Diff line change
@@ -20,8 +20,6 @@
#include "meta/test/TestUtils.h"
#include "webservice/WebService.h"

DECLARE_int32(ws_storage_http_port);

namespace nebula {
namespace meta {

3 changes: 0 additions & 3 deletions src/webservice/Common.cpp
Original file line number Diff line number Diff line change
@@ -7,9 +7,6 @@

#include <gflags/gflags.h>

DEFINE_int32(ws_meta_http_port, 11000, "Port to listen on Meta with HTTP protocol");
DEFINE_int32(ws_storage_http_port, 12000, "Port to listen on Storage with HTTP protocol");

namespace nebula {

std::unordered_map<HttpStatusCode, std::string> WebServiceUtils::kStatusStringMap_ = {
1 change: 1 addition & 0 deletions src/webservice/WebService.cpp
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@ DEFINE_string(ws_ip, "0.0.0.0", "IP/Hostname to bind to");
DEFINE_int32(ws_threads, 4, "Number of threads for the web service.");

#ifdef BUILD_STANDALONE
DEFINE_int32(ws_storage_http_port, 12000, "Port to listen on Storage with HTTP protocol");
DEFINE_int32(ws_storage_threads, 4, "Number of threads for the web service.");
#endif