Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lookup in crash when the property has no corresponding filter #3986

Merged
merged 5 commits into from
Mar 15, 2022

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Mar 8, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

FIx #3983

Description:

When the property in the IN expression does not have an index binding to it, it will not be rewritten to OR expression, and a crash will be caused by the DCHECK

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Aiee Aiee added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Mar 8, 2022
@Sophie-Xie Sophie-Xie merged commit 49db1ba into vesoft-inc:master Mar 15, 2022
@Aiee Aiee deleted the fix-rewriteInExpr branch March 15, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lookup ... WHERE xxx IN xxx causes service crash
4 participants