-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RPC client getResponse implementation #3977
Merged
yixinglu
merged 13 commits into
vesoft-inc:master
from
yixinglu:refactor-storage-client
Mar 23, 2022
Merged
Refactor RPC client getResponse implementation #3977
yixinglu
merged 13 commits into
vesoft-inc:master
from
yixinglu:refactor-storage-client
Mar 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
force-pushed
the
refactor-storage-client
branch
2 times, most recently
from
March 3, 2022 15:33
6192c0d
to
d1fd405
Compare
yixinglu
force-pushed
the
refactor-storage-client
branch
2 times, most recently
from
March 4, 2022 03:57
92af06c
to
0d0d4fa
Compare
yixinglu
force-pushed
the
refactor-storage-client
branch
7 times, most recently
from
March 7, 2022 10:18
b092688
to
8fc143d
Compare
yixinglu
changed the title
Refactor storage client collectResponse function
Refactor RPC client getResponse implementation
Mar 7, 2022
yixinglu
force-pushed
the
refactor-storage-client
branch
5 times, most recently
from
March 10, 2022 15:00
1e27ff3
to
7964780
Compare
yixinglu
force-pushed
the
refactor-storage-client
branch
5 times, most recently
from
March 16, 2022 15:48
5814d59
to
3906a86
Compare
critical27
reviewed
Mar 17, 2022
yixinglu
force-pushed
the
refactor-storage-client
branch
from
March 17, 2022 23:28
13eaa86
to
463a9c9
Compare
yixinglu
force-pushed
the
refactor-storage-client
branch
from
March 21, 2022 06:04
27409c4
to
b681a7f
Compare
critical27
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job~
yixinglu
requested review from
dutor,
cangfengzhs,
CPWstatic,
darionyaphet,
pengweisong and
wenhaocs
March 23, 2022 02:59
jievince
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
none
Description:
Use folly::collect and deferValue to simplify the collectResponse implementation. The promise usage is not user-friendly and hard to debug.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: