Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RPC client getResponse implementation #3977

Merged
merged 13 commits into from
Mar 23, 2022

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Mar 3, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

none

Description:

Use folly::collect and deferValue to simplify the collectResponse implementation. The promise usage is not user-friendly and hard to debug.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....
none

@yixinglu yixinglu force-pushed the refactor-storage-client branch 2 times, most recently from 6192c0d to d1fd405 Compare March 3, 2022 15:33
@yixinglu yixinglu force-pushed the refactor-storage-client branch 2 times, most recently from 92af06c to 0d0d4fa Compare March 4, 2022 03:57
@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Mar 4, 2022
@yixinglu yixinglu force-pushed the refactor-storage-client branch 7 times, most recently from b092688 to 8fc143d Compare March 7, 2022 10:18
@yixinglu yixinglu changed the title Refactor storage client collectResponse function Refactor RPC client getResponse implementation Mar 7, 2022
@yixinglu yixinglu force-pushed the refactor-storage-client branch 5 times, most recently from 1e27ff3 to 7964780 Compare March 10, 2022 15:00
@yixinglu yixinglu force-pushed the refactor-storage-client branch 5 times, most recently from 5814d59 to 3906a86 Compare March 16, 2022 15:48
@yixinglu yixinglu force-pushed the refactor-storage-client branch from 13eaa86 to 463a9c9 Compare March 17, 2022 23:28
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 21, 2022
@yixinglu yixinglu force-pushed the refactor-storage-client branch from 27409c4 to b681a7f Compare March 21, 2022 06:04
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@yixinglu yixinglu merged commit bdc95fe into vesoft-inc:master Mar 23, 2022
@yixinglu yixinglu deleted the refactor-storage-client branch March 23, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants