Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set auto_remove_invalid_space default true #3913

Merged
merged 3 commits into from
Feb 21, 2022
Merged

set auto_remove_invalid_space default true #3913

merged 3 commits into from
Feb 21, 2022

Conversation

liuyu85cn
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

some user complain why a dropped space still exist in disk.

Discussed before, just give this PR. auto remove invalid space.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

n/a

@liuyu85cn liuyu85cn added the ready-for-testing PR: ready for the CI test label Feb 18, 2022
@critical27 critical27 merged commit 6ed92c7 into vesoft-inc:master Feb 21, 2022
@critical27 critical27 deleted the set_auto_remote_space branch February 21, 2022 06:01
@jamieliu1023 jamieliu1023 mentioned this pull request Feb 26, 2022
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@nebula-bots @liuyu85cn
@critical27 @Sophie-Xie
set auto_remove_invalid_space default true (vesoft-inc#3913) (vesoft-…
0fd3513 
…inc#628)

Co-authored-by: Doodle <[email protected]>

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panda-sheep panda-sheep panda-sheep approved these changes

@critical27 critical27 critical27 approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuyu85cn @critical27 @panda-sheep