Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI feature file format checking failure caused by setuptools upgrading #3897

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Fix CI feature file format checking failure caused by setuptools upgrading #3897

merged 2 commits into from
Feb 15, 2022

Conversation

yixinglu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

setuptools upgrading will fail the gherkin feature file format checking.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

None

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Feb 15, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Feb 15, 2022
Aiee
Aiee previously approved these changes Feb 15, 2022
View reviewed changes
czpmango
czpmango previously approved these changes Feb 15, 2022
View reviewed changes
@yixinglu yixinglu dismissed stale reviews from czpmango and Aiee via bc3d031 February 15, 2022 09:38
@Sophie-Xie Sophie-Xie merged commit 847d3f3 into vesoft-inc:master Feb 15, 2022
@yixinglu yixinglu deleted the fix-ci branch February 15, 2022 10:01
Sophie-Xie pushed a commit that referenced this pull request Feb 15, 2022
@yixinglu @Sophie-Xie
Fix CI feature file format checking failure caused by setuptools upgr…
ea25ebf 
…ading (#3897)

* Fix CI feature file format checking failure caused by setuptools upgrading

* downgrade setuptools
@jamieliu1023 jamieliu1023 mentioned this pull request Feb 19, 2022
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@nebula-bots
Fix CI feature file format checking failure caused by setuptools upgr…
db0ae57 
…ading (vesoft-inc#3897) (vesoft-inc#618)

* Fix CI feature file format checking failure caused by setuptools upgrading

* downgrade setuptools

Co-authored-by: Yee <[email protected]>

Confirm with sophie.xie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czpmango czpmango czpmango approved these changes

@Aiee Aiee Aiee approved these changes

Assignees
No one assigned
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yixinglu @Aiee @czpmango @Sophie-Xie