-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix crash when schema version is greater than 255 #3893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
CPWstatic,
cangfengzhs,
zhaohaifei,
liwenhui-soul,
liuyu85cn,
panda-sheep,
SuperYoko and
pengweisong
February 15, 2022 08:05
liwenhui-soul
previously approved these changes
Feb 15, 2022
Sophie-Xie
added
cherry-pick-v3.0
PR: need cherry-pick to this version
cherry-pick-v2.6
PR: need cherry-pick to this version
ready-for-testing
PR: ready for the CI test
labels
Feb 15, 2022
CPWstatic
previously approved these changes
Feb 15, 2022
critical27
dismissed stale reviews from CPWstatic and liwenhui-soul
via
February 15, 2022 09:01
d70e001
Talked with @yixinglu offline, forbid the Gherkin format check now |
liwenhui-soul
previously approved these changes
Feb 15, 2022
CPWstatic
previously approved these changes
Feb 15, 2022
pengweisong
previously approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job~
critical27
dismissed stale reviews from pengweisong, CPWstatic, and liwenhui-soul
via
February 15, 2022 10:08
113431e
yixinglu
approved these changes
Feb 15, 2022
liwenhui-soul
approved these changes
Feb 15, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Feb 15, 2022
Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-v2.6
PR: need cherry-pick to this version
cherry-pick-v3.0
PR: need cherry-pick to this version
ready-for-testing
PR: ready for the CI test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#3889
Description:
Crash because of out-of-range access in vector.
The byte order of schema version in meta is not same as numerical order.
The output order in rocksdb when we prefix scan is quite complicated, just say a simple example with 257 schema versions in range
[0, 256]
, the order will be:255 254 253 ... 3 2 1 256 0
How do you solve it?
Just resize to make sure the vector is valid.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe:
Bug fix, fix crash when schema versions are more than 256