Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if leader changed during raft::appendLog() RPC, use a different error code #3880

Merged

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Feb 11, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

It is nature to return E_RAFT_TERM_OUT_OF_DATE or LEADER_CHANGE
when raft check leader, but this will make caller believe the append failed.

however, this log is replicated to followers(written in follower's WAL)
and the follower may become leader (use that WAL)
which means this log may eventually commit succeeded.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

n/a

@liuyu85cn liuyu85cn added the ready-for-testing PR: ready for the CI test label Feb 11, 2022
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@critical27 critical27 merged commit 47e1ed4 into vesoft-inc:master Feb 21, 2022
@critical27 critical27 deleted the treat_remote_leader_change_as_unknown branch February 21, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants