-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug fix] Need to wait for previous recover task finished. #3877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent
addPrime(spaceId, partId, termId, edgeKey, resumeVec[i]); | ||
} else { | ||
folly::Promise<folly::Unit> pro; | ||
auto fut = pro.getFuture(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: "pro" usually means good vs. con. It's better to use "p", "promise" or "xxPromise" to indicate promise.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
n/a
Description:
In TOSS, each time a raft part get leader, it will do a scan to see if there is any primes.
but if the leader changed really quick. There may be some previous term scan not finished. yet.
These to recover task will write the same key and finished in any order.
In this PR, the latest recover task will wait for previous task finish, then start.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
n/a