Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix] Need to wait for previous recover task finished. #3877

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Feb 10, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

n/a

Description:

In TOSS, each time a raft part get leader, it will do a scan to see if there is any primes.
but if the leader changed really quick. There may be some previous term scan not finished. yet.
These to recover task will write the same key and finished in any order.

In this PR, the latest recover task will wait for previous task finish, then start.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

n/a

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Contributor

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

addPrime(spaceId, partId, termId, edgeKey, resumeVec[i]);
} else {
folly::Promise<folly::Unit> pro;
auto fut = pro.getFuture();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: "pro" usually means good vs. con. It's better to use "p", "promise" or "xxPromise" to indicate promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants