skip heartbeat when role in meta client is not set #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
pengweisong,
cangfengzhs,
darionyaphet,
liuyu85cn,
liwenhui-soul,
panda-sheep,
SuperYoko and
HarrisChu
critical27
added
cherry-pick-v3.0
wenhaocs
approved these changes
Feb 7, 2022
Sophie-Xie
pushed a commit
that referenced
this pull request
Feb 8, 2022
critical27
added a commit
that referenced
this pull request
Feb 9, 2022
* skip heartbeat when role in meta client is not set (#3855) * Try to improve the performance of appendVertices (#3857) * Try to improve the performance of appendVertices * fix a unstable tck * keep consistent with 2.6.x (#3859) confirm with sophie.xie Co-authored-by: Doodle <[email protected]> Co-authored-by: jie.wang <[email protected]> Co-authored-by: Harris.Chu <[email protected]>
liwenhui-soul
pushed a commit
to liwenhui-soul/nebula
that referenced
this pull request
Feb 15, 2022
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* skip heartbeat when role in meta client is not set (vesoft-inc#3855) * fix failed ut Co-authored-by: Doodle <[email protected]> Manual merge due to unknown dismiss phenomenon，confirm with sophie.xie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #3854
Description:
The role in meta client is
UNKNOWNby default, and many tools use the defaultMetaClientOptions, which makes the host info isHost("", 0), and the info will be write to meta if we send heartbeat.How do you solve it?
Just skip heartbeat when role is unknown
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: