Unify remove to drop in schema and host #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
requested review from
dutor,
sherman-the-tank,
dangleptr and
laura-ding
laura-ding
reviewed
May 15, 2019
| : KW_REMOVE KW_TAG LABEL { | ||
| $$ = new RemoveTagSentence($3); | ||
| drop_tag_sentence | ||
| : KW_DROP KW_TAG LABEL { |
There was a problem hiding this comment.
would you remove several tag in one sentence ?
dangleptr
reviewed
May 15, 2019
| @@ -29,7 +29,7 @@ add_library( | |||
| InterimResult.cpp | |||
| VariableHolder.cpp | |||
| AddHostsExecutor.cpp | |||
| RemoveHostsExecutor.cpp | |||
| DropHostsExecutor.cpp | |||
There was a problem hiding this comment.
As for hosts, i think register/unregister is more reasonable.
Now, let's leave it here.
|
Please refer to [Reopen] Unify remove to drop in schema and host |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of #348