Memavailable #3534
Merged
Memavailable #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install lld when pull request , will set lld as default linker.
yixinglu
approved these changes
Dec 27, 2021
yixinglu
reviewed
Dec 27, 2021
| std::sort(memorySize.begin(), memorySize.end()); | ||
| if (memorySize.size() >= 2u) { | ||
| total = memorySize.back(); | ||
| available = memorySize[memorySize.size() - 2]; |
There was a problem hiding this comment.
free <= available <= total
Aiee
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
fix meminfo bug
Which issue(s)/PR(s) this PR relates to?
fix issue #3356
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: