Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable mixed usage of cypher & ngql #3506

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Dec 20, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

disable mixed usesage of cypher & ngql

Which issue(s)/PR(s) this PR relates to?

close #3477

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@nevermore3 nevermore3 changed the title disable mixed used of cypher & ngql disable mixed useage of cypher & ngql Dec 20, 2021
@nevermore3 nevermore3 changed the title disable mixed useage of cypher & ngql disable mixed usage of cypher & ngql Dec 20, 2021
@nevermore3 nevermore3 force-pushed the fix_subgraph_unwind_crash branch from 3d92ad6 to b2cd87f Compare December 20, 2021 10:19
@nevermore3 nevermore3 added the type/bug Type: something is unexpected label Dec 20, 2021
@nevermore3 nevermore3 added this to the v3.0.0 milestone Dec 20, 2021
@nevermore3 nevermore3 added doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test labels Dec 20, 2021
yixinglu
yixinglu previously approved these changes Dec 20, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shylock-Hg Shylock-Hg added the incompatible PR: incompatible with the recently released version label Dec 20, 2021
@Shylock-Hg
Copy link
Contributor

I think disable output to open cyher is enough, like #2537

@CPWstatic
Copy link
Contributor

I think disable output to open cyher is enough, like #2537

It's a great job. But there would have a more compatible implementation of match, so we could disable all of these usages now.

CPWstatic
CPWstatic previously approved these changes Dec 20, 2021
| n |
| ("Tim Duncan") |
| ("Tony Parker") |
Then a SyntaxError should be raised at runtime: syntax error near `UNION'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right, MATCH ... UNION MATCH ... is a legal cypher syntax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@CPWstatic CPWstatic dismissed their stale review December 20, 2021 11:35

See my comment.

@yixinglu yixinglu merged commit 53b85dc into vesoft-inc:master Dec 20, 2021
@nevermore3 nevermore3 deleted the fix_subgraph_unwind_crash branch December 20, 2021 15:28
@cooper-lzy
Copy link
Contributor

image

@cooper-lzy cooper-lzy removed the doc affected PR: improvements or additions to documentation label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwinding the result of subgraph crash the nebula-graphd
5 participants