Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send HB to meta leader #3498

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

darionyaphet
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@codecov-commenter
Copy link

Codecov Report

Merging #3498 (f0068e3) into master (99f1f7a) will decrease coverage by 0.01%.
The diff coverage is 93.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3498      +/-   ##
==========================================
- Coverage   85.19%   85.18%   -0.02%     
==========================================
  Files        1304     1304              
  Lines      121308   121344      +36     
==========================================
+ Hits       103352   103366      +14     
- Misses      17956    17978      +22     
Impacted Files Coverage Δ
src/clients/storage/StorageClient.h 100.00% <ø> (ø)
src/clients/storage/StorageClientBase-inl.h 72.53% <ø> (-0.15%) ⬇️
src/graph/validator/MutateValidator.h 100.00% <ø> (ø)
src/storage/mutate/AddEdgesProcessor.h 100.00% <ø> (ø)
src/storage/mutate/AddVerticesProcessor.h 100.00% <ø> (ø)
src/storage/mutate/AddEdgesProcessor.cpp 58.22% <78.57%> (+1.55%) ⬆️
src/storage/mutate/AddVerticesProcessor.cpp 83.64% <83.33%> (-5.46%) ⬇️
src/clients/meta/MetaClient.cpp 74.47% <100.00%> (-0.08%) ⬇️
src/clients/storage/StorageClient.cpp 78.51% <100.00%> (+0.07%) ⬆️
src/graph/executor/mutate/InsertExecutor.cpp 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92167b6...f0068e3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants