Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tck test cases for session #3486

Merged
merged 5 commits into from
Dec 22, 2021
Merged

add tck test cases for session #3486

merged 5 commits into from
Dec 22, 2021

Conversation

HarrisChu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

add tck test cases for session

@HarrisChu HarrisChu requested a review from Aiee December 16, 2021 09:06
@HarrisChu HarrisChu added the ready-for-testing PR: ready for the CI test label Dec 16, 2021
Aiee
Aiee previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #3486 (44bcac2) into master (53b85dc) will increase coverage by 0.03%.
The diff coverage is 85.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3486      +/-   ##
==========================================
+ Coverage   85.19%   85.23%   +0.03%     
==========================================
  Files        1306     1307       +1     
  Lines      122158   122550     +392     
==========================================
+ Hits       104078   104452     +374     
- Misses      18080    18098      +18
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/common/expression/VariableExpression.cpp 84.84% <ø> (-0.45%) ⬇️
src/common/geo/GeoIndex.h 100.00% <ø> (ø)
src/graph/executor/maintain/EdgeIndexExecutor.cpp 92.06% <ø> (ø)
src/graph/executor/maintain/TagIndexExecutor.cpp 92.80% <ø> (ø)
...rc/graph/executor/query/AppendVerticesExecutor.cpp 98.30% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.cpp 94.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.cpp 96.77% <ø> (ø)
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <ø> (ø)
src/graph/optimizer/rule/IndexScanRule.h 100.00% <ø> (ø)
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e7f45...44bcac2. Read the comment docs.

Aiee
Aiee previously approved these changes Dec 17, 2021
View reviewed changes
@Aiee Aiee requested review from jievince and Shylock-Hg December 17, 2021 07:11
@Aiee Aiee mentioned this pull request Dec 20, 2021
Merged
7 tasks
Shylock-Hg
Shylock-Hg previously approved these changes Dec 21, 2021
View reviewed changes
@Aiee Aiee dismissed stale reviews from Shylock-Hg and themself via 393a2cc December 21, 2021 03:17
@Aiee Aiee requested a review from Shylock-Hg December 21, 2021 03:17
Aiee
Aiee previously approved these changes Dec 21, 2021
View reviewed changes
Shylock-Hg
Shylock-Hg previously approved these changes Dec 21, 2021
View reviewed changes
@HarrisChu HarrisChu dismissed stale reviews from Shylock-Hg and Aiee via bcbb576 December 22, 2021 02:05
@HarrisChu HarrisChu requested a review from Aiee December 22, 2021 02:06
jievince
jievince approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 408d731 into vesoft-inc:master Dec 22, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Dec 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

@Aiee Aiee Aiee approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg left review comments

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HarrisChu @codecov-commenter @Aiee @Shylock-Hg @jievince @yixinglu @Sophie-Xie