Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3436

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Update README.md #3436

merged 2 commits into from
Dec 8, 2021

Conversation

yyh0808
Copy link
Contributor

@yyh0808 yyh0808 commented Dec 8, 2021

Solve the problem of nebula graph logo image file display in night mode
Screen Shot 2021-12-08 at 5 34 54 PM

Solve the problem of nebula logo image file display in night mode
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Dec 8, 2021
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #3436 (f08cb93) into master (d6f83f3) will increase coverage by 0.02%.
The diff coverage is 98.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.02%     
==========================================
  Files        1278     1278              
  Lines      119200   119267      +67     
==========================================
+ Hits       101608   101696      +88     
+ Misses      17592    17571      -21     
Impacted Files Coverage Δ
src/common/utils/NebulaKeyUtils.h 80.68% <ø> (ø)
src/common/utils/Types.h 100.00% <ø> (ø)
src/storage/exec/GetPropNode.h 89.55% <87.50%> (-0.45%) ⬇️
src/common/memory/MemoryUtils.cpp 93.33% <100.00%> (+0.65%) ⬆️
src/common/utils/MetaKeyUtils.cpp 82.15% <100.00%> (+0.78%) ⬆️
src/common/utils/NebulaKeyUtils.cpp 94.51% <100.00%> (+0.31%) ⬆️
src/common/utils/test/MetaKeyUtilsTest.cpp 94.63% <100.00%> (+0.30%) ⬆️
src/kvstore/test/DiskManagerTest.cpp 99.19% <100.00%> (+0.21%) ⬆️
src/storage/CompactionFilter.h 78.50% <100.00%> (ø)
src/storage/exec/UpdateNode.h 79.95% <100.00%> (+0.04%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38fc07...f08cb93. Read the comment docs.

@yixinglu yixinglu merged commit 6ccf173 into vesoft-inc:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants