Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inconsistent variable in yield and from clause #3430

Merged

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Dec 8, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Fix inconsistent variable in yield and from clause.

Which issue(s)/PR(s) this PR relates to?

#3210

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

                   `

@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Dec 8, 2021
@czpmango czpmango force-pushed the fix/variable-from-yield-inconsistent branch from f140d09 to 8755104 Compare December 8, 2021 08:19
@Shylock-Hg Shylock-Hg added the type/bug Type: something is unexpected label Dec 8, 2021
@czpmango czpmango force-pushed the fix/variable-from-yield-inconsistent branch from 8755104 to 9b05e98 Compare December 8, 2021 08:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #3430 (88af04f) into master (6ccf173) will increase coverage by 0.02%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3430      +/-   ##
==========================================
+ Coverage   85.25%   85.27%   +0.02%     
==========================================
  Files        1278     1278              
  Lines      119277   119285       +8     
==========================================
+ Hits       101688   101720      +32     
+ Misses      17589    17565      -24     
Impacted Files Coverage Δ
src/graph/validator/GoValidator.cpp 96.25% <72.72%> (-0.94%) ⬇️
src/meta/processors/BaseProcessor.h 75.67% <0.00%> (-16.22%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
src/parser/GraphScanner.h 91.46% <0.00%> (-2.29%) ⬇️
src/graph/util/SchemaUtil.cpp 92.82% <0.00%> (-0.40%) ⬇️
src/common/datatypes/ValueOps-inl.h 61.29% <0.00%> (-0.21%) ⬇️
src/common/datatypes/GeographyOps-inl.h 51.12% <0.00%> (-0.15%) ⬇️
src/common/datatypes/Value.cpp 75.21% <0.00%> (+0.10%) ⬆️
src/kvstore/NebulaStore.cpp 69.69% <0.00%> (+0.13%) ⬆️
src/clients/meta/MetaClient.cpp 76.36% <0.00%> (+0.16%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ccf173...88af04f. Read the comment docs.

@yixinglu yixinglu merged commit cd2f4a6 into vesoft-inc:master Dec 9, 2021
@yixinglu yixinglu linked an issue Dec 9, 2021 that may be closed by this pull request
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Jan 4, 2022
@cooper-lzy cooper-lzy added the incompatible PR: incompatible with the recently released version label Jan 5, 2022
@cooper-lzy cooper-lzy requested a review from foesa-yang January 5, 2022 02:58
@foesa-yang foesa-yang removed the doc affected PR: improvements or additions to documentation label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable not referred in from clause
8 participants